Extract _WatchedFieldBase to share logic between sync and async watchers#95
Merged
Conversation
…async field logic The two WatchedField classes shared ~90% of their implementation but had no common base, causing drift (the sync version acquired a lock in _update but then read _value outside it for the callback; the async version had no lock at all). Extract _WatchedFieldBase with _apply_raw and _fire_callbacks helpers. Both subclasses call super().__init__, inherit path/on_change/__bool__, and delegate value-mutation to the base—with or without a lock as appropriate. The three _RECONNECT_* constants are also consolidated in the new module. Closes #60 Co-Authored-By: Claude <noreply@anthropic.com>
zeevdr
added
size: M
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WatchedFieldandAsyncWatchedFieldshared ~90% of their code with no base class, causing silent drift (the sync version read_valueoutside its own lock when firing callbacks; the async version had no equivalent guard at all)._WatchedFieldBasewith_apply_rawand_fire_callbackshelpers so the mutation and notification logic lives in exactly one place._RECONNECT_*constants that were copy-pasted into both modules.Test plan
make test— all 227 tests pass, coverage 97.3% (above 95% threshold)_watcher_base.pyreaches 100% coverage via the existing watcher test suitesmake lint— ruff clean, no format driftCloses #60